Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swag Shipment Form #1397

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Conversation

abhirajadhikary06
Copy link
Contributor

@abhirajadhikary06 abhirajadhikary06 commented Dec 10, 2024

Fixes Issue🛠️

Closes #1393

Description👨‍💻

Built a swag shipment form with all kinds of necessary placeholders. A screenshot of the same has been attached.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

image

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 4e8b4dc
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/675a73d0d4cbbe0008d09feb
😎 Deploy Preview https://deploy-preview-1397--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abhirajadhikary06, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@abhirajadhikary06
Copy link
Contributor Author

@Rakesh9100 Made a PR please check.

@Rakesh9100
Copy link
Owner

Fix the previous PR commits shown in this PR commits tree, don't create a new PR, fix the issue in this one itself.
Also add your form in forms.html file @abhirajadhikary06

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Dec 11, 2024
@Rakesh9100 Rakesh9100 changed the title Address form Added Swag Shipment Form Dec 11, 2024
@abhirajadhikary06
Copy link
Contributor Author

Fix the previous PR commits shown in this PR commits tree, don't create a new PR, fix the issue in this one itself. Also add your form in forms.html file @abhirajadhikary06

I have made different branch to make my work clean and segregated.
I will be adding this Swag Shipment Form to forms.html. Other than this if you could tell me what I exactly need to do it would be clear for me to understand and work on it asap.

@Rakesh9100
Copy link
Owner

Please enhance the UI properly, visibility is too less @abhirajadhikary06

@abhirajadhikary06
Copy link
Contributor Author

@Rakesh9100 Enhanced the UI of the form

  • Added a dark color to the navbar
  • Add a card background behind the placeholders
  • Increased the fonts used in the body of the form
  • When clicked on the placeholder a dark green color is used to focus the particular placeholder

@Rakesh9100
Copy link
Owner

Check two other forms files are deleted, don't be in hurry and make quality PR else your PRs will not be merged @abhirajadhikary06

@abhirajadhikary06
Copy link
Contributor Author

Yes I have seen those form files but they were on my "address-form" branch so I have removed those.
I'm sorry for deleting those files.

@Rakesh9100 Rakesh9100 merged commit 89d15b0 into Rakesh9100:main Dec 12, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @abhirajadhikary06

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion KWOC KWOC Open Source Program and removed question 🤔 Further information is requested labels Dec 12, 2024
@abhirajadhikary06
Copy link
Contributor Author

@Rakesh9100 thank you for merging this PR

@Rakesh9100 Rakesh9100 added the Hard Complex or challenging task label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Hard Complex or challenging task KWOC KWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Swag Shipment Form
2 participants