Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Easier to follow log #1658

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

nirs
Copy link
Member

@nirs nirs commented Nov 20, 2024

Additional log cleanups split from #1628:

  • remove the file:line since it make it harder to follow the log and does not add much value.
  • Remove unhelpful noise from test name "Deploy", "busybox"
    • deploy will be useful when we add other workloads (statefulset, daemonset, vm)
    • busybox can be removed - the name will be in the specific workload debug logs

nirs added 2 commits November 20, 2024 18:24
This info is usually not helpful and harmful by taking spaces needed for
important info in the logs. When logging error we have file:lineno info
in the traceback.

Example log with this change:

    === RUN   TestSuites/Exhaustive/Deploy-cephfs#01/Appset/Enable
    2024-10-30T16:46:14.331+0200	INFO	enter EnableProtection appset-deploy-rbd-busybox
    2024-10-30T16:46:14.331+0200	INFO	enter EnableProtection appset-deploy-cephfs-busybox
    2024-10-30T16:46:16.995+0200	INFO	deployment busybox is ready
    2024-10-30T16:46:16.995+0200	INFO	workload Deploy-rbd is ready
    2024-10-30T16:46:16.995+0200	INFO	disapp-deploy-rbd-busybox is deployed

Part-of: RamenDR#1597
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Adding the same text to all workload is not helpful. Shorter names
are important to make it easy to scan the logs.

Currently with test everything with deployment using busybox image. When
we will add new workload we can consider changing the names, but we need
just one word to make the workload unique.

I want to add vm based tests later, but these will run with a special
environment, so they can use different test suite.

Example logs with this change:

    2024-10-31T19:39:11.391+0200	INFO	subscr-rbd	Protecting workload
    2024-10-31T19:39:11.467+0200	INFO	appset-rbd	Workload running on dr1
    2024-10-31T19:39:11.467+0200	INFO	appset-rbd	Annotating placement
    2024-10-31T19:39:11.467+0200	INFO	appset-cephfs	Workload running on dr2
    2024-10-31T19:39:11.467+0200	INFO	appset-cephfs	Annotating placement
    2024-10-31T19:39:11.467+0200	INFO	subscr-rbd	Workload running on dr1
    2024-10-31T19:39:11.467+0200	INFO	subscr-rbd	Annotating placement
    2024-10-31T19:39:11.485+0200	INFO	appset-cephfs	Creating drpc
    2024-10-31T19:39:11.571+0200	INFO	appset-rbd	Creating drpc
    2024-10-31T19:39:11.767+0200	INFO	subscr-rbd	Creating drpc
    2024-10-31T19:40:37.560+0200	INFO	disapp-rbd	drpc is ready

Fixes: RamenDR#1597
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
@nirs nirs changed the title E2e log format extra Easier to follow e2e log Nov 20, 2024
@nirs nirs changed the title Easier to follow e2e log e2e: Easier to follow log Nov 20, 2024
@nirs
Copy link
Member Author

nirs commented Nov 26, 2024

Summary from discussion with @raghavendra-talur:

We want to replace the current format:

{deployer}-Deploy-{rbd|cephfs}-busybox

With:

{deploy|statefulset|daemonset|vm}-{block|file}-{deployer}-{volrep|volsync}

(I'm not sure about the order)

So the tests are about:

  • The workload
  • The volume mode (different modes need different deployment script for busybox)
  • The way the workload is deployed
  • The way we protect the workload

And not about specific storage provider (rbd, cephfs) - Ramen is storage agnostic.

The config determines the particular storage to use for the test. The same test will work on drenv, openshift, k8s, with any compatible storage,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant