Initial ramen label changes #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeet219
force-pushed
the
label-ramen
branch
from
5a64cd9 to
45da485
Compare
|
Please add content to the commit message/pr message explaining the purpose of the change and linking to the relevant issues. |
nirs
reviewed
Jan 13, 2025
abhijeet219
force-pushed
the
label-ramen
branch
3 times, most recently
from
7ead978 to
58250a1
Compare
|
We need to add another label ramendr.openshift.io/exclude=true |
raghavendra-talur
requested changes
Mar 7, 2025
|
I have two comments asking for changes. In addition to that, please add the commit messages like Nir has requested. We should also write a unit test/e2e that verifies that all the objects have the label. |
abhijeet219
force-pushed
the
label-ramen
branch
from
58250a1 to
fcf8404
Compare
BenamarMk
reviewed
Mar 21, 2025
raghavendra-talur
requested changes
Mar 21, 2025
abhijeet219
force-pushed
the
label-ramen
branch
2 times, most recently
from
ef186d1 to
108f820
Compare
|
@abhijeet219 please rebase to fix the test failures. |
abhijeet219
force-pushed
the
label-ramen
branch
from
e66cd6b to
8a5f341
Compare
raghavendra-talur
approved these changes
Apr 3, 2025
raghavendra-talur
requested changes
Apr 4, 2025
Introducing a label to be added to all the resources created by Ramen. Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
raghavendra-talur
approved these changes
Apr 4, 2025
raghavendra-talur
approved these changes
Apr 4, 2025
BenamarMk
reviewed
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new label to be added to all the resources created by Ramen.
Addressing issue