Initial ramen label changes #1741
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
abhijeet219
force-pushed
the
label-ramen
branch
from
5a64cd9 to
45da485
Compare
|
Please add content to the commit message/pr message explaining the purpose of the change and linking to the relevant issues. |
nirs
reviewed
Jan 13, 2025
| @@ -28,6 +28,8 @@ const ( | |||
| path = "velero/" | |||
| protectsPath = path + "backups/" | |||
| recoversPath = path + "restores/" | |||
|
|
|||
| drCConfigCreatedByLabel = "ramendr.openshift.io/resource-created-by-ramen" | |||
There was a problem hiding this comment.
This label is duplicated, there should be exactly one variable shared by all code using it and maybe the test expecting this value.
This should also be a constant since it should never change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress...
Adding label to all resources deployed by ramen.
Addressing issue