recipe: inverseOp addition for exec hooks #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RestoreFailOn string | ||
| } | ||
|
|
||
| type PvcSelector struct { |
There was a problem hiding this comment.
This is a duplicate of this in vrg_pvc_selector.go with another function getPVCSelector(). Need to check if the code can be simplified.
| for _, execPod := range execPods { | ||
| err := executeCommand(&execPod, e.Hook, e.Scheme, log) | ||
| if err != nil && getOpHookOnError(e.Hook) == defaultOnErrorValue { | ||
| return fmt.Errorf("error executing exec hook: %w", err) | ||
| log.Error(err, "error executing command on pod", "pod", execPod.PodName, |
There was a problem hiding this comment.
I think we need to account for essential step and workflow on error conditions.
There was a problem hiding this comment.
Just had a little more analysis on this topic and IMO, hook/ops/onError (fail/continue) should be considered instead of workflow.failOn and hook.essential as the combination will be for overall workflow execution. Please correct me if wrong.
asn1809
force-pushed
the
asn-exec-inverse-op
branch
4 times, most recently
from
3841dd4 to
cd70af8
Compare
Adding implementation for inverse operation if provided for the exec hook. The changes include: 1. Move RecipeElements to util so that it can be re-used without import cycle and update all the references. 2. If the exec hook fails and inverseOp is specified, get the matching captureSpec or recoverSpec from the recipeElements and execute the hook. 3. If the inverseOp matching recoverSpec or captureSpec is not found, then return error. 4. In case captureSpec or recoverSpec is found, create a temp ExecHook and then call the functions which obtains all the relevant pods and then execute the commands. Modified the implementation to: 1. Send the recipe expanded version embedded in RecipeElements, 2. When executing inverseOp, refer to the recipe and get the hook spec needed for hook execution. 3. Execute inverseOp hook. Signed-off-by: Annaraya Narasagond <annarayanarasagond@gmail.com>
asn1809
force-pushed
the
asn-exec-inverse-op
branch
from
cd70af8 to
c6738ee
Compare
raghavendra-talur
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding implementation for inverse operation if provided for the exec hook. The changes include: