Use sig_atomic_t Instead of bool for Signal Handling

- Using `bool` in signal handlers leads to undefined behavior. - `sig_atomic_t` ensures the flag is set reliably when catching signals.
RaphiaRa · Sep 30, 2024 · 64ebad3 · 64ebad3
1 parent c457ff9
commit 64ebad3
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 17 deletions.
diff --git a/examples/custom_logger.c b/examples/custom_logger.c
@@ -8,13 +8,12 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-static bool running = true;
+static sig_atomic_t stop = 0;
 
 static void
 sigint_handler(int signum)
 {
-    (void)signum;
-    running = false;
+    stop = signum;
 }
 
 static th_err
@@ -64,7 +63,7 @@ int main(int argc, char** argv)
         goto cleanup;
     if ((err = th_route(server, TH_METHOD_GET, "/", handler, NULL)) != TH_ERR_OK)
         goto cleanup;
-    while (running) {
+    while (!stop) {
         th_poll(server, 1000);
     }
     fprintf(stderr, "Shutting down...\n");

diff --git a/examples/echo.c b/examples/echo.c
@@ -5,12 +5,12 @@
 #include <stdlib.h>
 #include <string.h>
 
-static bool running = true;
+static sig_atomic_t stop = 0;
 
-static void sigint_handler(int signum)
+static void 
+sigint_handler(int signum)
 {
-    (void)signum;
-    running = false;
+    stop = signum;
 }
 
 const char* method_strings[] = {
@@ -68,7 +68,7 @@ int main(int argc, char** argv)
         goto cleanup;
     if ((err = th_route(server, TH_METHOD_ANY, "/{path:path}", handler, NULL)) != TH_ERR_OK)
         goto cleanup;
-    while (running) {
+    while (!stop) {
         th_poll(server, 1000);
     }
     fprintf(stderr, "Shutting down...\n");

diff --git a/examples/file_server.c b/examples/file_server.c
@@ -5,13 +5,12 @@
 #include <stdlib.h>
 #include <string.h>
 
-static bool running = true;
+static sig_atomic_t stop = 0;
 
 static void
 sigint_handler(int signum)
 {
-    (void)signum;
-    running = false;
+    stop = signum;
 }
 
 static th_err
@@ -89,7 +88,7 @@ int main(int argc, char** argv)
         goto cleanup;
     if ((err = th_route(server, TH_METHOD_GET, "/", handle_index, NULL)) != TH_ERR_OK)
         goto cleanup;
-    while (running) {
+    while (!stop) {
         th_poll(server, 1000);
     }
     fprintf(stderr, "Shutting down...\n");

diff --git a/examples/hello_world.c b/examples/hello_world.c
@@ -5,13 +5,12 @@
 #include <stdlib.h>
 #include <string.h>
 
-static bool running = true;
+static sig_atomic_t stop = 0;
 
 static void
 sigint_handler(int signum)
 {
-    (void)signum;
-    running = false;
+    stop = signum;
 }
 
 static th_err
@@ -37,7 +36,7 @@ int main(int argc, char** argv)
         goto cleanup;
     if ((err = th_route(server, TH_METHOD_GET, "/", handler, NULL)) != TH_ERR_OK)
         goto cleanup;
-    while (running) {
+    while (!stop) {
         th_poll(server, 1000);
     }
     fprintf(stderr, "Shutting down...\n");