Add more attributes to AppCommandChannel #10345
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR (once again) adds more attributes to
AppCommandChannelRational behind some of the decisions made:
Noneif the channel doesn't have a certain field. This avoids implying a channel has the feature/field when it actually doesn't. For instance,slowmode_delaywithCategoryChannel, if we return 0, it implies that it has a slowmode of 0s, when it actually doesn't have that feature.slowmode_delayis nowOptional[int]which makes it a breaking change. If this isn't a good idea, i'll revert it!Checklist