Changed how firingrate is scaled to maximum for BVCs. #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To scale the firingrates of BVCs to between
min_fr
andmax_fr
, a maximum firingrate for each BVC must be computed during initialization.The previous approach was to compute a within-environment estimate. However, particularly for FieldOfViewBVCs where head direction and position conjunctively determine firingrates, these values were sometimes being underestimated (see #110). Improving the estimates with more samples would be computationally demanding.
This PR proposes a new approach in which max firingrates are computed analytically as the maximum possible activity for each BVC (i.e., the firing rate for each BVC, if its receptive field is fully occupied by a boundary):
Notes for users:
max_fr
should now be more accurate. However, in a few cases (i.e., for BVCs with very small receptive fields), the maximum observed firing rate may still slightly overshoot themax_fr
. This appears to be due to numerical error (see BVC firingrates go over max_fr #110 for details), and was mostly observed when using"uniform_manifold"
cell arrangements.