-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring Read the Docs to publish the MPS manual #141
Conversation
Bootstrap issue: If the Read the Docs manual goes away, and someone has a bare MPS tree, how can they read the manual? The readme.txt does not lead to instructions for how to build and read it. |
https://memory-pool-system.readthedocs.io/en/latest/design/index.html is blank, so Read the Docs didn't run Sphinx in the same way as "make html" would. |
Examining the Read the Docs build output at https://readthedocs.org/projects/memory-pool-system/builds/19364054/ reveals that it's invoking Sphinx with
whereas we invoke it with Line 48 in 4108cc4
So Read the Docs is building with "manual/source" as the current working directory. That causes this glob to find no design documents mps/manual/source/extensions/mps/designs.py Line 162 in 4108cc4
|
Fixed in 409aea1 by using You can see that the designs are converted in https://readthedocs.org/projects/memory-pool-system/builds/19364368/ output from the Sphinx command and at https://memory-pool-system.readthedocs.io/en/branch-2023-02-02-readthedocs/design/index.html |
…lding the manual from the MPS tree <#141 (comment)>.
…b so that the glob results are not relative. Oops.
Fixed in 380b43d which also closes #144 . Results visible at https://memory-pool-system.readthedocs.io/en/branch-2023-02-02-readthedocs/guide/build.html#building-the-mps-manual |
Review suggestion: Check https://memory-pool-system.readthedocs.io/en/branch-2023-02-02-readthedocs/index.html against https://www.ravenbrook.com/project/mps/master/manual/html/ to make sure building with Read the Docs hasn't broken anything. They ought to be identical in content, except for changes made in this branch. |
@UNAA008 spotted a couple of warnings from Read the Docs:
Investigate. |
https://github.com/Ravenbrook/mps/blob/631d30ea5cc1307f801ec2b6d0c3444e6f411172/manual/source/extensions/mps/__init__.py is not well commented, and it's hard to discern the intention, but these are definitely deliberate overrides. I think adding commentary or working out whether and how to suppress these warnings is outside the scope of this pull request and not very important. |
…ferences to design.mps.doc.
The manual on Read the Docs doesn't seem to have a search. Investigate. https://dnd-srd-sphinx.readthedocs.io/en/latest/index.html has a search. I suspect this is to do with our custom theme. We may be able to inherit the search from Read the Docs themes. |
GitHub deleted my express review record. Reconstructing... We executed proc.review.express.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proc.review.exit.pass
Executing proc.merge.pull-request.
|
Added to #140 (comment)
Fixed in 6fa80f4
Created #160
Created #161 |
Adds CI configuration to build the MPS manual and publish it at https://memory-pool-system.readthedocs.io/ .
CI will help us know sooner if the manual breaks.
Migrates away from Ravenbrook internal automation that publishes at https://www.ravenbrook.com/project/mps/master/manual/html/ . See #98 (comment) .
Fixes #118.