-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update actions/checkout
to v4
from v3
.
#284
ci: Update actions/checkout
to v4
from v3
.
#284
Conversation
This updates internally to using Node 20 and removes some deprecation notices within the GitHub Actions UI about Node 16 being deprecated.
Executing proc.review.express:
Checking commences 15:50. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing proc.review.check
- Start time 15:51.
- m. It's not entirely clear why we have to say "@v4" except that's what GitHub gives as an example and it works. It seems likely to be stable for a long time though. The README for the checkout project refers to it as "V4". Probably best practice. I skimmed a few best practices and security documents. If want to be really hard about it we might say @<hash>.
Executing proc.review.express.brainstorm:
|
That indicates which git tag to use, indicating which version should be used. The v4 keeps it on the 4.x version. |
…ify why we say "@v4", in response to review comment <#284 (review)>.
Yes. I was more wondering why that's how it's done. Not a big deal though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ify why we say "@v4", in response to review comment <#284 (review)>.
Executing proc.merge.pull-request.
|
Except I fell foul of Git's constant astonishment and caused the merge commit to vanish on master. See #228 (comment) . Always follow written procedure where GIt is concerned. |
This updates internally to using Node 20 and removes some deprecation notices within the GitHub Actions UI about Node 16 being deprecated.