Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell GitHub not to cancel builds in the posix matrix #296

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

rptb1
Copy link
Member

@rptb1 rptb1 commented Nov 26, 2024

Fixes #295 according to Handling failures.

@rptb1 rptb1 added the build Problems with builds and build automation label Nov 26, 2024
@rptb1 rptb1 self-assigned this Nov 26, 2024
@rptb1 rptb1 added the low risk This work is or would be of low risk of introducing defects. label Nov 27, 2024
@rptb1
Copy link
Member Author

rptb1 commented Nov 27, 2024

Executing proc.review.express.

  1. Start time 11:43.
  2. Applying entry.universal. Note that for entry.universal.auto-check all automatic checks have not passed (macos-latest build failed) but that is expected, and useful, since it demonstrated that the other posix matrix builds were not cancelled.
  3. Calling in @thejayps . There will be a short delay.

@thejayps
Copy link
Contributor

  1. express.risk, agree low risk and appropriate for express review
  2. Source docs: Running variations of jobs in a workflow
  3. No defects found by me or @rptb1
  4. .express.brainstorm @rptb1 "could we have noticed that this could be an issue when setting up the build? Can't think of any process improvement to make"
  5. Executing proc.review.exit
  6. Exit Start time 12:22
  7. Change passed.
  8. review.exit.calc:
  • hours used: 0.5
  • hours saved: ~5-6h repeating builds
  • major defects remaining: 0
  1. Exit finished at 12:28: 6 mins

@thejayps thejayps self-requested a review November 27, 2024 12:29
Copy link
Contributor

@thejayps thejayps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rptb1 rptb1 merged commit cbfc54b into master Nov 27, 2024
12 of 15 checks passed
@rptb1
Copy link
Member Author

rptb1 commented Nov 27, 2024

Executing proc.merge.pull-request

  1. Start time 12:27.
  2. All checklist items pass except "pass tests" as noted above. The "automated test case" is to notice cancelled builds.
  3. Using GitHub's "Merge button" to replace section 5, "Merging procedure", because this is a one-commit PR that does not require a local build.
  4. End time 12:31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Problems with builds and build automation low risk This work is or would be of low risk of introducing defects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub cancells build jobs in the posix matrix when any of them fails
3 participants