-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing use of deprecated alias of VersionChange #297
Conversation
…in Sphinx 8 <https://www.sphinx-doc.org/en/master/changes/8.0.html#release-8-0-0-released-jul-29-2024> and breaks the manual build.
Executing proc.review.express.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing proc.review.check.
- Start time 12:55.
- Checked out the branch and ensured I could build the manual with:
cd manual
make clean
rm -r tool
make html
- Checked the Sphinx version of the successful manual build with
./tool/bin/sphinx-build --version
and got "sphinx-build 8.1.3" which matches the version run by Read the Docs. - Checking finished 12:59.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking - no defects found after 6 minutes
Continuing proc.review.express. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rptb1 has done exit.pass
Executing proc.merge.pull-request.
|
Deprecated alias
sphinx.directives.other.VersionChange
was removed in Sphinx 8 https://www.sphinx-doc.org/en/master/changes/8.0.html#release-8-0-0-released-jul-29-2024 and this breaks the manual build.This also breaks manual builds on Read The Docs, e.g. https://readthedocs.org/projects/memory-pool-system/builds/26405165/
Update to the recommended
sphinx.domains.changeset.VersionChange
.