Prevent NROs from the original game from being double-registered. #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coolsonickirby
approved these changes
Aug 17, 2023
Raytwo
requested changes
Aug 22, 2023
Cargo.toml
Outdated
| @@ -63,6 +63,8 @@ serde_yaml = "0.8" | |||
| smash-bgm-property = "1.2.0" | |||
| # For inputs | |||
| ninput = { git = "https://github.com/blu-dev/ninput" } | |||
| # For reading in NRR hashes | |||
| binrw = "0.11.2" | |||
There was a problem hiding this comment.
Genuinely don't think you need a heavy dependency like binrw to read such a simple file? Can you really need not parse it with regular Rust methods?
There was a problem hiding this comment.
The latest commit addresses this, however, I have yet to test the change on console.
Raytwo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for NROs whose hashes are inside the original games' NRR files to replace NROs via ARCropolis.
(ex: replacing
prebuilt:/nro/release/lua2cpp_roy.nrowith a byte-identical dump fromdata.arc)