[WIP] Refactor noise function construction #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like not all fractal noise functions take exactly the same parameters, so maybe having a common trait for them doesn't make sense. As far as I can tell, the only reason to define the constructors via traits at all is to avoid a small amount of boilerplate, so perhaps the way forwards is to remove |
|
Closing as, in the absence of any feedback, I cannot move this forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of the API refactoring proposed in #197, with usability tweaks as discussed in IRC. I'd like to get some feedback before proceeding further. Changes were applied to
BasicMultiandPerlinas a hopefully-representative sample, with some redundant code left in place to keep the crate as a whole building until the proposed APIs are more widely implemented.The most significant impact of this change is that fractal noise functions are constructed with all parameters supplied up front. This is necessary because no meaningful seed value can be saved for RNG-produced noise functions in the general case, and has the incidental benefits of reduced boilerplate and that redundant work is no longer performed when constructing a noise function with a non-default seed or octaves.