std::string_view support in Rcpp::wrap() #1356
Merged
+34
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Rcpp::wrap()
treats astd::string_view
argument by default as a generic container and creates a character vector from single characters. This is different from howstd::string
is handled. This change aligns the two, so thatwrap("foo"sv)
is equivalent towrap("foo"s)
. The added code is conditionally compiled for C++17.Checklist
R CMD check
still passes all tests