Changes to ensure test(number instead of test(name

[MichaelChirico]

Related to #6040 -- it will be good to keep to a pattern where test() always has a numeric literal in the num= argument, even if it's a dynamic test where the base number is incremented by a variable amount. Doing so will make the testPattern= argument to test.data.table() more usable.

We can add a linter for this (#5908) to prevent regression later.

Linter to find these:

l=make_linter_from_xpath(
  "//SYMBOL_FUNCTION_CALL[text() = 'test']/parent::expr/following-sibling::expr[1][SYMBOL or expr[1]/SYMBOL]",
  "xxx")
lint("inst/tests/tests.Rraw", l())

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (898dce3) to head (3daf44d).
Report is 4 commits behind head on master.

❗ Current head 3daf44d differs from pull request most recent head a21e48d. Consider uploading reports for the commit a21e48d to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6041   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          80       80           
  Lines       14915    14915           
=======================================
  Hits        14547    14547           
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MichaelChirico]

• Allow running a subset of tests by pattern #6040
• Changes to ensure test(number instead of test(name #6041 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MichaelChirico and the rest of your teammates on Graphite