Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defunct autostart from fread() #6832

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Remove defunct autostart from fread() #6832

merged 2 commits into from
Mar 10, 2025

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Feb 23, 2025

Finishing the deprecation cycle: 9fd1e22 -> #6653

@MichaelChirico MichaelChirico changed the title remove autostart Remove defunct autostart from fread() Feb 23, 2025
@MichaelChirico MichaelChirico marked this pull request as ready for review February 23, 2025 06:38
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (885bdb3) to head (f62143d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6832      +/-   ##
==========================================
- Coverage   98.59%   98.59%   -0.01%     
==========================================
  Files          79       79              
  Lines       14663    14662       -1     
==========================================
- Hits        14457    14456       -1     
  Misses        206      206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Feb 23, 2025

Comparison Plot

Generated via commit f62143d

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 37 seconds
Installing different package versions 8 minutes and 6 seconds
Running and plotting the test cases 2 minutes and 20 seconds

@MichaelChirico MichaelChirico changed the base branch from depr-logasint to graphite-base/6832 February 25, 2025 06:34
Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

@MichaelChirico MichaelChirico changed the base branch from graphite-base/6832 to master March 10, 2025 19:42
@MichaelChirico MichaelChirico merged commit 7e41884 into master Mar 10, 2025
10 checks passed
@MichaelChirico MichaelChirico deleted the depr-autostart branch March 10, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants