Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rebuild-email-verification-and-data-ownership-mechanism #771

Conversation

ericbolikowski
Copy link
Contributor

@ericbolikowski ericbolikowski commented Aug 22, 2023

What Github issue does this PR relate to? Insert link.

#765, #769

What should the reviewer know?

(will write later)

@ericbolikowski
Copy link
Contributor Author

Current state of affairs:

  • CON signup modified to include email verification and delaying write of any data to SF until email is verified
  • We still need to test/implement the mechanism to become the owner of a Contact record that already exists with the email of the user signing up - this will probably require some smaller changes to jwt.strategy.ts
  • Finally, we need to transfer all of this to TP as well, and test that cross-platform login/signup works as expected

After that's done, before deployment, see the notes in #765.

@ericbolikowski
Copy link
Contributor Author

Update:

  • We completed the mechanism that lets a new user get associated to a pre-existing SF Contact with same email
  • Code grew quite complex, notably in jwt.strategy.ts. Kate will have a go at commenting/refactoring it
  • Eric will work on making this work in TP as well while in the air on Friday

@ericbolikowski
Copy link
Contributor Author

Update:

  • Began refactoring TP to also have email-verification-on-sign-up
  • So far done: distinct TP email verification email template; store all form data with RedUser object for both jobseeker and company mode; update of RedUser to .emailVerified = true works; email verification succeeded page put into place.
  • Remains: logic on first login into TP as jobseeker/company, inserting into TP the signup data
  • Also remains: make cross-platform sign-up logic work

@ericbolikowski
Copy link
Contributor Author

Alright, the first complete version of this is finally ready for review.

Please pay special attention to headlines and text in pages and emails after each action in the sign-up flow. There's likely some improvements we should do.

We need to get this out ASAP, so shortcuts are allowable. As long as there's no obvious big mistakes, we should deploy this if it's good enough. Maybe we can get Asya and Ligia to then do a product/UX review to find minor tweaks we can do to make it better.

@katamatata, please test and review the scenarios:

  1. Mentee signs up on CON
  2. Mentor signs up on CON
  3. User with jobseeker profile on TP signs up on CON (meaning, he logs in with same credentials)
  4. Jobseeker signs up on TP
  5. User with CON profile signs up on TP as jobseeker (meaning, he logs in with same credentials)
  6. Representative for new company signs up on TP
  7. Representative for existing company signs up on TP

@helloanil, please test the ones relevant for TP

@ericbolikowski ericbolikowski marked this pull request as ready for review September 20, 2023 11:02
@ericbolikowski ericbolikowski merged commit ac5e497 into master Sep 22, 2023
2 checks passed
@ericbolikowski ericbolikowski deleted the feat/rebuild-email-verification-and-data-ownership-mechanism branch September 22, 2023 07:13
@katamatata katamatata linked an issue Sep 22, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CON/Mentor/Sign-up] Update 'Sign-up complete' e-mail and page for mentors
2 participants