Faut tout review goodluck #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EltyDev
reviewed
Nov 25, 2024
EltyDev
reviewed
Nov 25, 2024
| } | ||
|
|
||
| d_config = new DiscordSocketConfig { | ||
| GatewayIntents = GatewayIntents.All, // un peu la flemme mais apres on pourra def les vrai autorisations |
EltyDev
reviewed
Nov 25, 2024
EltyDev
requested changes
Nov 25, 2024
EltyDev
reviewed
Nov 25, 2024
source/configuration/ConfigFile.cs
Outdated
| @@ -0,0 +1,10 @@ | |||
| namespace Configuration | |||
| { | |||
| public class Config | |||
There was a problem hiding this comment.
Privé les champs d'une classe
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
EltyDev
reviewed
Nov 27, 2024
EltyDev
reviewed
Nov 27, 2024
| { | ||
| class Config | ||
| { | ||
| public string Token { get; set; } |
There was a problem hiding this comment.
Mets les champs de tes classes en privé (hors exceptions)
There was a problem hiding this comment.
pas serializable si mis en privee de memoire
EltyDev
reviewed
Nov 27, 2024
source/maintenance/Logger.cs
Outdated
EltyDev
requested changes
Nov 27, 2024
…AAAAAAAAAAAAAAAAAAAAAAAA fix :3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.