Skip to content

fix: Add back missing log by naming logger correctly #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

kitadai31
Copy link

this::javaClass.name returns a wrong name

println(this::javaClass.name)
// javaClass

println(this::class.java.name)
// app.revanced.patcher.patch.BytecodePatchContext

And the logger is configured to output logs whose loggerName starts with "app.revanced".
As a result, log messages in BytecodePatchContext was not printed on both CLI and Manager.
This PR fixes this problem.

@kitadai31
Copy link
Author

Additional information: Other usage of Logger.getLogger() are fine
Only this part is using javaClass in getLogger()

@oSumAtrIX
Copy link
Member

I debugged this over half an hour and couldn't figure out what was wrong, lol

@oSumAtrIX oSumAtrIX changed the title fix: Compiling patched dex files log is not printed fix: Add back missing log by using intended logger name Jan 19, 2025
@oSumAtrIX oSumAtrIX changed the title fix: Add back missing log by using intended logger name fix: Add back missing log by naming logger correctly Jan 19, 2025
@oSumAtrIX oSumAtrIX merged commit e4e66b0 into ReVanced:dev Jan 19, 2025
1 check failed
Copy link

welcome bot commented Jan 19, 2025

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

@kitadai31 kitadai31 deleted the patch-1 branch January 20, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants