fix(YouTube Music - Spoof video streams): Use IOS_MUSIC client
#4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix playback issues
oSumAtrIX
commented
Dec 14, 2024
extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/ClientType.java
Show resolved
Hide resolved
|
Seems like the issue still occurs, further debugging will be needed |
# Conflicts: # extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/ClientType.java # extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/SpoofVideoStreamsPatch.java # patches/src/main/kotlin/app/revanced/patches/music/misc/spoof/SpoofVideoStreamsPatch.kt
LisoUseInAIKyrios
approved these changes
Dec 15, 2024
LisoUseInAIKyrios
changed the title
IOS_MUSIC client to fix playback issuesIOS_MUSIC client
|
Superseded by #4132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the VR client, iOS Music is now used. This confirmed fixing playback issues for VR client users. No exceptions are logged using the VR client, so the playback itself failed for some reason. Using the iOS Music client type fixes the issue. It is unclear if other side effects exist such as stable volume.