Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Adjoint Sensitivities #237

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Fix Adjoint Sensitivities #237

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29f6718
replace DiffEqSensitivity with SciMLSensitivity
mjohnson541 Oct 2, 2023
97cbe16
adapt adjoint_sensitivity syntax
mjohnson541 Oct 2, 2023
0cd3601
increase absolute tolerances for test runs in adjoint sensitivities
mjohnson541 Feb 7, 2024
f0aa710
Remove parametrized typing from getadjointsensitivities
mjohnson541 Feb 7, 2024
e80bb70
Fix type stability in getadjointsensitivities
mjohnson541 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Simulation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,8 @@ By default uses the InterpolatingAdjoint algorithm with vector Jacobian products
this assumes no changes in code branching during simulation, if that were to become no longer true, the Tracker
based alternative algorithm is slower, but avoids this concern.
"""
function getadjointsensitivities(bsol::Q, target::String, solver::W; sensalg::W2=InterpolatingAdjoint(autojacvec=ReverseDiffVJP(false)),
abstol::Float64=1e-6, reltol::Float64=1e-3, normalize=true, kwargs...) where {Q,W,W2}
function getadjointsensitivities(bsol::Simulation, target::String, solver; sensalg=InterpolatingAdjoint(autojacvec=ReverseDiffVJP(false)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove typing for W and W2?

abstol::Float64=1e-6, reltol::Float64=1e-3, normalize=true, kwargs...)
@assert target in bsol.names || target in ["T", "V", "P", "mass"]

pethane = 160
Expand Down