Skip to content

Commit

Permalink
Use GitHub as source
Browse files Browse the repository at this point in the history
  • Loading branch information
@hwpang
hwpang committed May 14, 2023
1 parent 4b558fb commit d5d8524
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions pyrms/meta.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
{% set version = "0.1.2" %}
{% set version = "1.0.2" %}
{% set name = "pyrms" %}

package:
name: pyrms
version: {{ version }}

source:
fn: {{ name }}-{{ version }}.tar.gz
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: d3a8929d5c66a80cc17469c3d82991182d566ad53c5b9d427d4f94ce2bcf73e5
git_rev: main
git_url: https://github.com/ReactionMechanismGenerator/pyrms.git

build:
number: '1'
Expand Down

1 comment on commit d5d8524

@rwest
Copy link
Member

@rwest rwest commented on d5d8524 May 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a specific "version" number (1.0.2) and build number ('rmg_1' and 1) yet is not using a specific version of the code - just whatever happens to be on github at the time you run the build script. Which was only run for linux-64. The latest release on github is 0.1.0. The latest release on PyPI is 1.0.1
So who knows what 1.0.2 is?

(update just to add: sorry the above message was rather rude. I wrote it too quickly. I apologize)

Please sign in to comment.