Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(multiple) better assault rifle description #1746

Merged
merged 12 commits into from
Nov 20, 2024

Conversation

Duke-M-commits
Copy link
Member

@Duke-M-commits Duke-M-commits commented Nov 9, 2024

After reading about the description of the assault rifle being a bit confusing on Discord i went to fix it.

I've also machine-retranslated it, but since we do not have active translators for all languages I went and indented the ones for which there is no one to look after (danish, hungarian, polish, portuguese, spanish, turkish).

Please review:
brazilian @Mart-User or @FurtadoPires
finnish @Crazymanbos
french @wawawawawawawa
italian @MakinDay or @Steffo99
japanese @Deerlord0 or @finishtw
korean @hangumi or @BRAIN-IS-BACK or @906bc906
latam @gaelcoral
russian @Blueberryy
schinese @ModdedMarionette or @ywgATustcbbs or @zhongqingsong
swedish @Crazymanbos
tchinese @ModdedMarionette or @Crazy3lf or @mewindng
ukrainian @MsSockol
vietnamese @DucDuyGaming

PS: you can suggest a change to any line like this
image

Copy link
Contributor

@Steffo99 Steffo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds a bit better to me!

resource/reactivedrop_italian.txt Outdated Show resolved Hide resolved
Duke-M-commits and others added 2 commits November 9, 2024 01:26
Co-authored-by: Stefano Pigozzi <me@steffo.eu>
Copy link
Contributor

@ModdedMarionette ModdedMarionette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave Traditional Chinese to the others as I do not believe I am as qualified.

resource/reactivedrop_schinese.txt Outdated Show resolved Hide resolved
Co-authored-by: ModdedMarionette <87785920+ModdedMarionette@users.noreply.github.com>
Co-authored-by: finish <apple41906@gmail.com>
Copy link
Contributor

@Crazymanbos Crazymanbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the text a little.

resource/reactivedrop_swedish.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@Deerlord0 Deerlord0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sent a fix for new AR description.

resource/reactivedrop_japanese.txt Outdated Show resolved Hide resolved
Duke-M-commits and others added 4 commits November 11, 2024 15:43
Co-authored-by: 한구미 <152593623+hangumi@users.noreply.github.com>
Co-authored-by: Crazymanbos <89078143+Crazymanbos@users.noreply.github.com>
Copy link
Contributor

@DucDuyGaming DucDuyGaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I forgot to submit the review, here you go

resource/reactivedrop_vietnamese.txt Outdated Show resolved Hide resolved
Duke-M-commits and others added 3 commits November 12, 2024 14:27
Co-authored-by: Nguyễn Đức Duy <117811607+DucDuyGaming@users.noreply.github.com>
@Duke-M-commits
Copy link
Member Author

Duke-M-commits commented Nov 19, 2024

I've indented lines which nobody found time to look at (brazilien, french, latam, russian).
@BenLubar I think we're good to go.

@Duke-M-commits Duke-M-commits marked this pull request as ready for review November 19, 2024 13:03
@BenLubar BenLubar merged commit 4a2b114 into ReactiveDrop:master Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.