Revamp our live deployment and dev preview model and workflows #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
roedoejet
approved these changes
May 8, 2024
dhdaines
approved these changes
May 8, 2024
joanise
added a commit
that referenced
this pull request
May 8, 2024
Finishes deploying the dev preview from #281 already merged in deploy, now merging it into main too, so it's our model everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Overhaul the way we deploy the Studio-Web app to https://readalong-studio.mothertongues.org/
deploywill now update the live version on https://readalong-studio.mothertongues.org/main(or merging a PR) will now update the dev preview version at https://readalong-studio.mothertongues.org/dev/This is not quite what we agreed on: we were going to deploy from
mainand preview fromdev, but I decideddeployandmainmade more sense because in every project,mainis our development branch, and I think it would have caused frequent confusion to change that model here.Still to do (future PR): make the live deployment use the published bundle, in sync with npm.
Note: I created the
deploybranch and pointed it at the last commit that uses web-component 1.3.0 unmodified. When we merge this PR todeploy, the live deployment will roll back to not have the gear menu, which will only be visible on the dev preview for now, until we publish 1.4.0 and re-deploy.Feedback sought?
Feedback on the model itself and my choice of branch names.
Workflow code feedback.
Priority?
high
Tests added?
This can't be tested automatically, but I tested by running these workflows on my fork.
See
These don't work because I'm block by CORS from the API, but if you look at the network traffic you'll see it's loading what we expect, and if you look at the gh-pages branch on https://github.com/joanise/Studio-Web you'll see the expected structure.
I have validated that main, dev and pr-previews don't interfere with each other.
How to test?
No need, unless you want to redo my fork tests on your own fork.
Confidence?
High
Version change?
nope