Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete PR previews when the PR is closed #292

Merged
merged 1 commit into from
May 16, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented May 15, 2024

PR Goal?

Auto-clean up PR previews

Fixes?

Fixes #285

Feedback sought?

rubber stamping

Priority?

normal

Tests added?

n/a, the test will be looking at what happens when we merge this PR in.

How to test?

merge the PR. Kinda late, but it's a trivial PR

Confidence?

high, I followed the simple instructions at https://github.com/marketplace/actions/deploy-pr-preview

Version change?

no

@joanise joanise requested review from dhdaines and roedoejet May 15, 2024 13:20
Copy link
Contributor

github-actions bot commented May 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-16 14:31 UTC

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I haven't seen this syntax before. I assume it's been tested out in some way?

@joanise joanise merged commit cf066d7 into main May 16, 2024
2 checks passed
@joanise joanise deleted the dev.ej/delete-pr-preview-on-close branch May 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up PR previews once we're done with them
2 participants