build: make bundle compatible with Windows and test it in CI #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CI, let's this npx nx bundle web-component on both Windows and Linux, and on Linux let's display the diff in a way that we can see the bits that changed even though it's minified.
|
Review changes with SemanticDiff. Analyzed 1 of 4 files.
|
|
dhdaines
approved these changes
Sep 25, 2024
| node b64Fonts.js | ||
| npx webpack --config webpack.config.js | ||
| packageVersion=$(npm view ../../node_modules/@readalongs/web-component version) | ||
| timestamp=$(date "+%Y-%m-%d+%H-%M-%S") |
There was a problem hiding this comment.
Guessing that if you have bash on Windows then you also have date?
There was a problem hiding this comment.
Yeah, once you're in bash, you get the standard *nix command line tools, even on Windows, through msys, mingw64, cygwin or some derivative. I'm not aware of any instance of bash on Windows that's not based on one of those. Git systematically comes with Git Bash on Windows, that's the one I always use now, it's lightweight but has everything I need to make my Windows machine pleasant to use.
| @@ -15,7 +15,7 @@ | |||
| "dist/" | |||
| ], | |||
| "scripts": { | |||
| "bundle": "node b64Fonts.js && webpack --config webpack.config.js; packageVersion=$(npm view ../../node_modules/@readalongs/web-component version); timestamp=$(date \"+%Y-%m-%d+%H-%M-%S\") && cd ../studio-web && npm pkg set singleFileBundleVersion=\"${packageVersion}\" && npm pkg set singleFileBundleTimestamp=\"${timestamp}\"", | |||
| "bundle": "bash bundle.sh", | |||
There was a problem hiding this comment.
well, that's ... much nicer looking
joanise
added a commit
that referenced
this pull request
Oct 16, 2024
In CI, let's this npx nx bundle web-component on both Windows and Linux, and on Linux let's display the diff in a way that we can see the bits that changed even though it's minified. To make bundle compatible with Windows, I turned the one liner in `package.json` into a script that is much easier to read and maintain.
joanise
added a commit
that referenced
this pull request
Oct 16, 2024
In CI, let's this npx nx bundle web-component on both Windows and Linux, and on Linux let's display the diff in a way that we can see the bits that changed even though it's minified. To make bundle compatible with Windows, I turned the one liner in `package.json` into a script that is much easier to read and maintain.
joanise
added a commit
that referenced
this pull request
Oct 17, 2024
In CI, let's this npx nx bundle web-component on both Windows and Linux, and on Linux let's display the diff in a way that we can see the bits that changed even though it's minified. To make bundle compatible with Windows, I turned the one liner in `package.json` into a script that is much easier to read and maintain. (cherry picked from commit 1690f7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI, let's this npx nx bundle web-component on both Windows and Linux, and on Linux let's display the diff in a way that we can see the bits that changed even though it's minified.
PR Goal?
Make
npx nx bundle web-componentcompatible with Windows, and exercise it in CIFixes?
the fact that the bundle command was specifically a bash command, but did not enforce being rush by bash
Feedback sought?
rubber stamping
Priority?
low
Tests added?
yes
How to test?
run
npx nx bundle web-componenton Windows and see it no longer failConfidence?
high
Version change?
no