Dev.del/fix-editor-translations #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
deltork
force-pushed
the
dev.del/fix-editor-translations
branch
from
d638da6 to
34816da
Compare
|
@joanise I have streamlined the translation management as discussed. |
fix: deletion of translation
deltork
force-pushed
the
dev.del/fix-editor-translations
branch
from
b2e23d7 to
34bb35c
Compare
joanise
approved these changes
Nov 8, 2024
| "sentence-id", | ||
| ); | ||
|
|
||
| translation[sentenceID] = sentence.textContent; |
There was a problem hiding this comment.
We maybe want to null out lastAlignedSentenceId here too, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Complete the implementation of the translation management in the editor
Fixes?
Various issues with the translations in the editor
Feedback sought?
Adding/remove/updating translations in the studio and editor. Also finding missing edge cases.
Priority?
HIGH
Tests added?
Will be part of the studio test suites
How to test?
Confidence?
HIGH
Version change?
patch
This patch does not use the agreed upon model we discussed. It just fixes the issues so we can proceed to adding tests before the work to change the modeling is done.