-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev.del/feat studio e2e #375
Conversation
|
4b0f50a
to
598b98f
Compare
2f9e987
to
a3146ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to want to test this locally a bit, but just some comments for now.
@@ -62,6 +68,7 @@ | |||
"jszip": "^3.10.1", | |||
"mime": "^4.0.1", | |||
"ngx-toastr": "^18.0.0", | |||
"root": "file:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird, what does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh! something in my configuration keeps adding them! I will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This slipped back in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disabled all my plugins, but they keep popping up!
409e0bc
to
de73323
Compare
…nd reduce runtime test(ci): setup of matrix sharding to deal with test timeout
de73323
to
6860c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, and I think we can merge it already.
Trivial detail: the "root": "file" line is back in. Is it innocuous? Maybe we could just leave it in if it doesn't hurt, I just wish I understood what it means. There's another "file" entry, too, for studio-web depending on web-component: file. Again, what does this mean?
Locally, three tests don't pass on Firefox, mostly due to exact alignments, but I don't think we need to hold the PR back for this.
6860c13
to
c46a5ec
Compare
It's something my VS Code keeps adding
|
Bring end to end tests to Studio-Web
PR Goal?
Bring end to end tests to Studio-Web
Fixes?
Feedback sought?
sanity
Priority?
High
Tests added?
packages\studio-web\tests\studio-web.spec
How to test?
check out the branch and run
npx nx e2e studio-web
Confidence?
High
Version change?
n/a
The testing the editor will be another PR