Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev.del/feat studio e2e #375

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Dev.del/feat studio e2e #375

merged 6 commits into from
Dec 11, 2024

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented Nov 20, 2024

PR Goal?

Bring end to end tests to Studio-Web

Fixes?

Feedback sought?

sanity

Priority?

High

Tests added?

packages\studio-web\tests\studio-web.spec

How to test?

check out the branch and run npx nx e2e studio-web

Confidence?

High

Version change?

n/a

The testing the editor will be another PR

Copy link

semanticdiff-com bot commented Nov 20, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  packages/studio-web/src/app/shared/download/download.component.html  67% smaller
  packages/studio-web/package.json  45% smaller
  packages/studio-web/src/app/upload/upload.component.html  38% smaller
  packages/studio-web/src/app/soundswallower.service.ts  38% smaller
  package-lock.json  9% smaller
  .github/workflows/end-to-end-tests.yml Unsupported file format
  .gitignore Unsupported file format
  .husky/post-install Unsupported file format
  package.json  0% smaller
  packages/studio-web/playwright.config.ts  0% smaller
  packages/studio-web/src/app/demo/demo.component.html  0% smaller
  packages/studio-web/src/app/upload/upload.component.ts  0% smaller
  packages/studio-web/tests/fixtures/page1.png Unsupported file format
  packages/studio-web/tests/fixtures/page2.png Unsupported file format
  packages/studio-web/tests/fixtures/ref/edited/readalong.eaf Unsupported file format
  packages/studio-web/tests/fixtures/ref/edited/readalong.srt Unsupported file format
  packages/studio-web/tests/fixtures/ref/edited/readalong.textgrid Unsupported file format
  packages/studio-web/tests/fixtures/ref/edited/readalong.vtt Unsupported file format
  packages/studio-web/tests/fixtures/ref/edited/sentence-paragr-date.readalong Unsupported file format
  packages/studio-web/tests/fixtures/ref/readalong.eaf Unsupported file format
  packages/studio-web/tests/fixtures/ref/readalong.srt Unsupported file format
  packages/studio-web/tests/fixtures/ref/readalong.textgrid Unsupported file format
  packages/studio-web/tests/fixtures/ref/readalong.vtt Unsupported file format
  packages/studio-web/tests/fixtures/test-sentence-paragraph-page-56k.mp3 Unsupported file format
  packages/studio-web/tests/studio-web/check-page-1.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/download-elan.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/download-html.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/download-praat.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/download-srt.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/download-web-bundle.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/download-webvtt.spec.ts  0% smaller
  packages/studio-web/tests/studio-web/make-read-along.spec.ts  0% smaller
  packages/studio-web/tests/test-cases.md Unsupported file format
  packages/studio-web/tests/test-commands.ts  0% smaller
  packages/web-component/src/components/read-along-component/read-along.tsx  0% smaller

Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-11 20:11 UTC

@deltork deltork force-pushed the dev.del/feat-studio-e2e branch 7 times, most recently from 4b0f50a to 598b98f Compare November 25, 2024 14:26
@deltork deltork force-pushed the dev.del/feat-studio-e2e branch from 2f9e987 to a3146ca Compare November 29, 2024 20:48
@deltork deltork requested review from joanise and roedoejet November 29, 2024 20:49
@deltork deltork self-assigned this Nov 29, 2024
@deltork deltork marked this pull request as ready for review November 29, 2024 21:26
@deltork deltork requested a review from dhdaines December 2, 2024 14:43
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to want to test this locally a bit, but just some comments for now.

@@ -62,6 +68,7 @@
"jszip": "^3.10.1",
"mime": "^4.0.1",
"ngx-toastr": "^18.0.0",
"root": "file:",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, what does this mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh! something in my configuration keeps adding them! I will remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slipped back in.

Copy link
Collaborator Author

@deltork deltork Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled all my plugins, but they keep popping up!

packages/studio-web/.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/end-to-end-tests.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/studio-web/.gitignore Outdated Show resolved Hide resolved
packages/studio-web/.nycrc Outdated Show resolved Hide resolved
packages/studio-web/package.json Outdated Show resolved Hide resolved
packages/studio-web/playwright.config.ts Outdated Show resolved Hide resolved
@deltork deltork force-pushed the dev.del/feat-studio-e2e branch from 409e0bc to de73323 Compare December 6, 2024 17:20
@deltork deltork force-pushed the dev.del/feat-studio-e2e branch from de73323 to 6860c13 Compare December 6, 2024 17:31
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, and I think we can merge it already.
Trivial detail: the "root": "file" line is back in. Is it innocuous? Maybe we could just leave it in if it doesn't hurt, I just wish I understood what it means. There's another "file" entry, too, for studio-web depending on web-component: file. Again, what does this mean?

Locally, three tests don't pass on Firefox, mostly due to exact alignments, but I don't think we need to hold the PR back for this.

@deltork deltork force-pushed the dev.del/feat-studio-e2e branch from 6860c13 to c46a5ec Compare December 11, 2024 19:56
@deltork
Copy link
Collaborator Author

deltork commented Dec 11, 2024

This is great, and I think we can merge it already. Trivial detail: the "root": "file" line is back in. Is it innocuous? Maybe we could just leave it in if it doesn't hurt, I just wish I understood what it means. There's another "file" entry, too, for studio-web depending on web-component: file. Again, what does this mean?

It's something my VS Code keeps adding

Locally, three tests don't pass on Firefox, mostly due to exact alignments, but I don't think we need to hold the PR back for this.
I slightly modified the evaluation of the output to help with that issue

@deltork deltork merged commit 6947180 into main Dec 11, 2024
7 checks passed
@deltork deltork deleted the dev.del/feat-studio-e2e branch December 11, 2024 20:11
deltork added a commit that referenced this pull request Dec 11, 2024
joanise added a commit that referenced this pull request Dec 11, 2024
Bring end to end tests to Studio-Web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants