Create an api to delete a role from the discord server #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
changed the title
iamitprakash
requested changes
Oct 29, 2024
pankajjs
changed the title
pankajjs
force-pushed
the
feat/delete-guild-role-api
branch
from
1961b68 to
6989c74
Compare
samarpan1738
reviewed
Nov 8, 2024
samarpan1738
reviewed
Nov 8, 2024
|
It is a delete endpoint. Therefore I have followed the REST standard for delete request with 204 status and empty body. |
samarpan1738
previously approved these changes
Nov 10, 2024
vikhyat187
reviewed
Nov 11, 2024
vikhyat187
reviewed
Nov 11, 2024
samarpan1738
previously approved these changes
Nov 11, 2024
joyguptaa
reviewed
Nov 11, 2024
joyguptaa
reviewed
Nov 11, 2024
pankajjs
dismissed stale reviews from samarpan1738 and vikhyat187
via
d28042b
joyguptaa
approved these changes
Nov 11, 2024
vinit717
approved these changes
Nov 11, 2024
samarpan1738
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 24 Oct, 2024
Developer Name: @pankajjs
Issue Ticket Number
Description
This PR adds a delete api endpoint for removing a role from RDS discord server which is going to be used in website backend for deleting a group role when a super user deletes the group from Group Site.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Working Video
dd1.mp4
Test Coverage
Screenshots
Additional information
Design doc Google Doc Link