feat: Add onboarding extension command to create an onboarding extension request #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
force-pushed
the
feat/create-onboarding-extension-command
branch
from
40742cd to
65ff578
Compare
pankajjs
changed the title
vinit717
reviewed
Jan 5, 2025
- Added command and handler - Changed required default value - Added constant message - Changed field name and argument - Fixed function argument and types - Added super user field - Added validation for super-user and fixed reply - Changed field, expectation message and test name as it was failing - Restore all mocks in after-each hook - Fixed lint issue - Added assert statement to verify the function call signature and fixed test name - Added tests to handle edge cases and fixed existing failing tests
pankajjs
force-pushed
the
feat/create-onboarding-extension-command
branch
from
4a3bdc8 to
532e48f
Compare
Achintya-Chatterjee
approved these changes
Jan 8, 2025
vinit717
approved these changes
Jan 13, 2025
This was referenced Jan 14, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 20 Dec, 2024
Developer Name: @pankajjs
Issue Ticket Number
Description
/onboarding-extension <number-of-days> <reason> <username>which interacts with website backend and creates an onboarding extension request for onboarding user.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Working Videos
output_time_0.mp4
output_time_1.mp4
d2.mp4
d4.mp4
d5.mp4
Test Coverage
Screenshot 1
Additional Notes
Design doc
PRD