input component created #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neha
reviewed
Jan 29, 2023
| type="textbox" | ||
| name={name} | ||
| value={value} | ||
| onChange={(e) => onChange(e.target.value)} |
There was a problem hiding this comment.
A few pieces of feedback:
- add onBlur and onFocus event
- add data-test-id
- can we also allow ...rest ?
Neha
reviewed
Jan 29, 2023
| @@ -1,8 +1,8 @@ | |||
| import StarbucksInput from './index.js'; | |||
| import StarbucksInput from './StarbucksInput'; | |||
| import { render, screen } from '@testing-library/react'; | |||
There was a problem hiding this comment.
3rd party imports should be on the top always
| import { render, screen } from '@testing-library/react'; | ||
| import userEvent from '@testing-library/user-event' | ||
|
|
||
| describe.skip('starbucks input tests', () => { | ||
| describe('starbucks input tests', () => { | ||
| test('it renders input component', async () => { | ||
| // Assemble | ||
| const elName = 'nickname'; |
There was a problem hiding this comment.
please use clear and elaborate variable names
|
|
||
| function App() { | ||
| return ( | ||
| <div className="App"> | ||
| <StarbucksInput/> |
There was a problem hiding this comment.
please clean the code not required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.