Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: login page #17

Merged
merged 2 commits into from
Sep 29, 2023
Merged

feat: login page #17

merged 2 commits into from
Sep 29, 2023

Conversation

gauravsinhaweb
Copy link
Contributor

@gauravsinhaweb gauravsinhaweb commented Sep 29, 2023

Issue / ticket

Tests covered __test__/pages/login

  • should render without throwing an error
  • should render username input
  • should render password input
  • should render the Login button
  • should accept a valid username that takes only alphanumeric characters and underscore
  • should not accept an invalid username that doesn't take only alphanumeric characters and underscore

Screenshot 2023-09-29 114813

Recording.2023-09-29.115055.mp4

@gauravsinhaweb gauravsinhaweb linked an issue Sep 29, 2023 that may be closed by this pull request
3 tasks
@gauravsinhaweb gauravsinhaweb self-assigned this Sep 29, 2023
__tests__/pages/login.js Outdated Show resolved Hide resolved
src/pages/login/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@j24m j24m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@iamitprakash iamitprakash merged commit f587e64 into develop Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create login page for tiny site
4 participants