Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New UI for profile update requests page #843

Merged
merged 8 commits into from
Sep 28, 2024
Merged

New UI for profile update requests page #843

merged 8 commits into from
Sep 28, 2024

Conversation

lakshayman
Copy link
Contributor

@lakshayman lakshayman commented Sep 23, 2024 •
edited
Loading

Date: 23/09/2024

Developer Name: @lakshayman

Issue

#849

Description

New UI for the profile update requests page.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No
Screenshare.-.2024-09-23.5_51_15.PM.1.1.mp4

@lakshayman lakshayman self-assigned this Sep 23, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2024 •
edited
Loading

Deploying dashboard-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: b3ea439
Status: ✅  Deploy successful!
Preview URL: https://a33975ed.dashboard-rds.pages.dev
Branch Preview URL: https://feat-profilediffsnewui.dashboard-rds.pages.dev

View logs

yesyash
yesyash requested changes Sep 24, 2024
View reviewed changes
profile-diff/local-utils.js Outdated Show resolved Hide resolved
profile-diff/local-utils.js Outdated Show resolved Hide resolved
profile-diff/local-utils.js Outdated Show resolved Hide resolved
profile-diff/local-utils.js Outdated Show resolved Hide resolved
profile-diff/local-utils.js Outdated Show resolved Hide resolved
profile-diff/style.css Outdated Show resolved Hide resolved
profile-diff/style.css Outdated Show resolved Hide resolved
profile-diff/style.css Outdated Show resolved Hide resolved
profile-diff/style.css Outdated Show resolved Hide resolved
profile-diffs/local-utils.js Outdated Show resolved Hide resolved
yesyash
yesyash requested changes Sep 24, 2024
View reviewed changes
profile-diff/constants.js Outdated Show resolved Hide resolved
profile-diffs/style.css Outdated Show resolved Hide resolved
profile-diffs/style.css Show resolved Hide resolved
profile-diffs/style.css Show resolved Hide resolved
profile-diffs/style.css Outdated Show resolved Hide resolved
@yesyash
Copy link
Contributor

yesyash commented Sep 24, 2024

  • @lakshayman why is this pr so big ? could we have broken this into two parts, one for profile diff details and other for profile diff listing?

@yesyash
Copy link
Contributor

yesyash commented Sep 24, 2024

@lakshayman you have created two folders profile-diff and profile-diffs, it's very hard to differentiate between the two, if we're rendering profile diff details in profile-diff can we name it to profile-diff-details?

MehulKChaudhari
MehulKChaudhari approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@MehulKChaudhari MehulKChaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lakshayman lakshayman merged commit b392270 into develop Sep 28, 2024
5 checks passed
@lakshayman lakshayman deleted the feat/profileDiffsNewUI branch September 28, 2024 08:03
@lakshayman lakshayman mentioned this pull request Sep 28, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesyash yesyash yesyash requested changes

@MehulKChaudhari MehulKChaudhari MehulKChaudhari approved these changes

Assignees

@lakshayman lakshayman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lakshayman @yesyash @MehulKChaudhari