Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: added total count for selected status and removed the view button for application card #853

Merged
merged 20 commits into from
Sep 28, 2024
Merged

enhancement: added total count for selected status and removed the view button for application card #853

merged 20 commits into from
Sep 28, 2024

Conversation

rishirishhh
Copy link
Member

@rishirishhh rishirishhh commented Sep 25, 2024 •
edited by Achintya-Chatterjee
Loading

Date: 25/09/2024

Developer Name: Kavya Rishi

Issue Ticket Number

Description

This contains the frontend changes which remove the View-Details button from the application card and whenever you hover over the application card the cursor changes to pointer and then superuser can click on the application card to view more details. This also contains the change which shows the total number of accepted/pending/rejected applications as per the selected filter.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Before:

Screenshot from 2024-09-25 18-09-57

Screenshot from 2024-09-25 18-12-25

After:

Screenshot from 2024-09-28 12-00-51

Test Coverage

Screenshot from 2024-09-27 00-16-40

Additional Notes

vinit717
vinit717 requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2024 •
edited
Loading

Deploying dashboard-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: fbacb8c
Status: ✅  Deploy successful!
Preview URL: https://86158d0f.dashboard-rds.pages.dev
Branch Preview URL: https://enhancement-add-pending-coun.dashboard-rds.pages.dev

View logs

@shubhdevelop
Copy link

Please add screenshot of the test coverage in PR description
and screencast of changes made, and how it's behaving

joyguptaa
joyguptaa previously approved these changes Sep 26, 2024
View reviewed changes
joyguptaa
joyguptaa previously approved these changes Sep 27, 2024
View reviewed changes
yesyash
yesyash previously approved these changes Sep 27, 2024
View reviewed changes
@vinit717
Copy link
Member

Please confirm the UI with Ankush as the alignment is not good

@yesyash yesyash dismissed their stale review September 27, 2024 19:34

cards, filter button and title are not aligned

yesyash
yesyash requested changes Sep 27, 2024
View reviewed changes
applications/index.html Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

You have removed the view details button now how does the super user view the details of the application?

@rishirishhh
Copy link
Member Author

You have removed the view details button now how does the super user view the details of the application?

I have removed the view details behind the dev flag
behind the dev flag the user can simply click on application modal
whenever you hover around the application card , cursor changes into pointer and you can click on it
@vinit717

@rishirishhh
Copy link
Member Author

Screencast from 28-09-24 01:29:53 PM IST.webm
@vinit717

@vinit717
Copy link
Member

Screencast from 28-09-24 01:29:53 PM IST.webm @vinit717

Cursor is not visible and text is not align with the card yet

@rishirishhh
Copy link
Member Author

Screencast from 28-09-24 01:29:53 PM IST.webm @vinit717

Cursor is not visible and text is not align with the card yet

cursor is not visible in screencast , I cannot do anything about that

@vinit717
Copy link
Member

Screencast from 28-09-24 01:29:53 PM IST.webm @vinit717

Cursor is not visible and text is not align with the card yet

cursor is not visible in screencast , I cannot do anything about that

Sorry But I cannot approve it without the proof

@rishirishhh
Copy link
Member Author

#859 issue to be resolved after this merge

vinit717
vinit717 reviewed Sep 28, 2024
View reviewed changes
applications/script.js Outdated Show resolved Hide resolved
yesyash
yesyash previously approved these changes Sep 28, 2024
View reviewed changes
@yesyash yesyash dismissed their stale review September 28, 2024 09:51

css was written in js

@prakashchoudhary07 prakashchoudhary07 merged commit 8667539 into develop Sep 28, 2024
5 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the enhancement/add-pending-count branch September 28, 2024 19:34
@rishirishhh rishirishhh mentioned this pull request Sep 28, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

@vinit717 vinit717 vinit717 approved these changes

@yesyash yesyash yesyash left review comments

@joyguptaa joyguptaa Awaiting requested review from joyguptaa

Assignees

@rishirishhh rishirishhh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement : There is an alignment issue with the new elements that are created in the applications page.
7 participants
@rishirishhh @shubhdevelop @vinit717 @Achintya-Chatterjee @joyguptaa @yesyash @prakashchoudhary07