Feature/Infinite-scrolling-feature-and-user-search-fix-on-user-management-page #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinit717
requested changes
Sep 28, 2024
yesyash
requested changes
Sep 28, 2024
yesyash
requested changes
Sep 28, 2024
prashant67690
force-pushed
the
fix/user-management-fix
branch
from
b0b9404
to
8667539
Compare
|
yash sir fixed the previous problems and also wrote the additional test as you requested please review |
prashant67690
changed the title
Ayushsanjdev
suggested changes
Oct 1, 2024
yesyash
approved these changes
Oct 1, 2024
vinit717
approved these changes
Oct 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 28-09-2024
Developer Name: Prashant Kumar
Issue Ticket Number
closes : #833
Description
The User Management page currently features infinite scroll loading of users and the users in the list view are now rendered as the list rather than in the form of cards / tiles , due these changes the search functionality was having issue , that thing is fixed and running as expected down below.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Before:
Screenshot 2
After:
Test Coverage
Screenshot 1
Additional Notes
here we can see the search functionality behavior after the fixes
2024-09-28.03-02-01.mp4