Feature/user data pagination #891
Conversation
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
…anVeer/website-dashboard into feature/user-data-pagination
|
We had this conversation previously: |
| let showUser = 0; | ||
| usersData[activeTab] = await getUsers(activeTab); | ||
|
|
||
| // usersData[activeTab] = await getUsers(activeTab); |
There was a problem hiding this comment.
Currently testing with mockdata and that function is still being used to fetch the actual data
| // createElement('span', {}, [ | ||
| // user.first_name + ' ' + user.last_name + user.username, | ||
| // ]), |
There was a problem hiding this comment.
can we get rid of this if not needed?
There was a problem hiding this comment.
Same, this is being currently used with the actual data I have just replicated my version to test out the mock data.
| return createElement('aside', { class: 'users_section' }, [ | ||
| createElement('div', { class: 'loading' }, ['Loading...']), | ||
| ]); |
There was a problem hiding this comment.
why not we create a common loader file? this can be re-used as well right?
| const debounce = (func, delay) => { | ||
| let timeoutId; | ||
| return function (...args) { | ||
| clearTimeout(timeoutId); | ||
| timeoutId = setTimeout(() => { | ||
| func.apply(this, args); | ||
| }, delay); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
can we move this into a separate file and export it and use here? this way if in future we need debounce in any other place, we can re-use
There was a problem hiding this comment.
fixed this: removed this function as it is already defined globally in utils.js file in the root folder line:62
users/discord/App.js
Outdated
| } else { | ||
| } |
Date: 15/10/2024
Developer Name: Ishan Veer
Issue Ticket Number
832
Description
Previously all the data was being fetched at once which can cause performance issues. So things I worked on:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Currently testing it with mock data because API is still not paginated.