Fix: Scrollability issue of users list for discord users #934
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinit717
requested changes
Jan 5, 2025
yesyash
requested changes
Jan 5, 2025
It was just the UX issue...so didn't update/write any tests. |
@shantanu-02 you have update the test screenshot, it's mandatory |
|
Hello @shantanu-02 can you please attach the test coverage screenshot |
vinit717
reviewed
Jan 28, 2025
Comment on lines
+59
to
+70
|
|
||
| createElement('div', { class: 'users_section' }, [ | ||
| UsersSection({ | ||
| users, | ||
| showUser, | ||
| handleUserSelected, | ||
| }), | ||
| ]), | ||
|
|
||
| createElement('div', { class: 'user_details_section' }, [ | ||
| UserDetailsSection({ user: users[showUser] ?? {} }), | ||
| ]), |
There was a problem hiding this comment.
Do we need to create the div here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 05/01/2025
Developer Name: Shantanu Pawar
Issue Ticket Number
Description
Made a separate container for the list of users so that the scrollability of the list doesn't affect the whole page.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot recording 1
Screen.Recording.2025-01-05.142752.mp4
Test Coverage
Screenshot 1
Additional Notes