Dev to Main Sync #1329
Merged
Dev to Main Sync #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 100% (#1322) * initial commit * refactor code * added feature flag * refactored some code * changed casing and removed comments * changed to predefined colouring * removed unnecessary useCallbacks * removed onstatus function * resolved commented changes * decereased the mismatch between the modal and design doc modal * changed button color * font change * used the already created modal component * dimensional changes * refactored function * small refactoring * async await updated * applied callback on close icon * refactored to named exports * removed a div element * rounded off the rem values * put the close icon inside button wrapper * rounded off rems * rounded off rem values
* Close button added * Added cross button on update modal * Formatting done * All Test Passed * Unnecessery Code Removed * Fix test to check if setIsOpen is called on close button click
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…progress to 100% (#1324) * initial changes * removed unnecessary lines * removed the onStatusChange tests * added one more check to ensure that the onclose() function is working * added more tests * added should before each line * added braces * added dev flag tests * added the testid check * added skip to tests * added skeleton components to pass linitng checks * added one more test case * removed skips * added a getAllByRole
|
Proof for #1312 loom-video.3.mp4
|
iamitprakash
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 11 Feb, 2025
Developer Name: @ZendeAditya @RishiChaubey31
Issue Ticket Number
PR going to Sync
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes