ADDED open in app dialog popup #690
Conversation
js/index.js
Outdated
| window.onload = femo(); | ||
|
|
||
| function femo() { | ||
| console.log('efd'); |
js/index.js
Outdated
| let regexp = /android|iphone|kindle|ipad/i; | ||
| let details = navigator.userAgent; | ||
| let isMobileDevice = regexp.test(details); | ||
| window.onload = femo(); |
|
Refactored code and written test cases @shreya-mishra |
__test__/index.test.js
Outdated
| }); | ||
| test(`don't show dialog if not open in phone`, () => { |
__test__/index.test.js
Outdated
| expect(result).toBe('true'); | ||
| }); | ||
| test(`don't show dialog if not open in phone`, () => { | ||
| const regexp = /Windows|macOS|/i; // for PC |
There was a problem hiding this comment.
| const regexp = /Windows|macOS|/i; // for PC | |
| const regexp = /Windows|macOS|/i; // for desktop devices |
js/index.js
Outdated
| document.getElementById('okayBt').addEventListener('click', openApp); | ||
| document.getElementById('cancleBt').addEventListener('click', closeDialog); |
There was a problem hiding this comment.
don't use shorthands for naming that are hard to understand, also there is typo in cancel button
js/index.js
Outdated
| var timeTaken = Date.now() - startTime; | ||
| if (timeTaken <= 1000) { | ||
| flag = true; | ||
| } | ||
| }); | ||
|
|
||
| setTimeout(function () { | ||
| if (!flag) { | ||
| document.body.removeChild(iframe); | ||
| window.location.href = fallbackURL; | ||
| } | ||
| }, 1000); // Adjust the delay as needed | ||
| } else { |
There was a problem hiding this comment.
What's the intention of this part of the code?
There was a problem hiding this comment.
- This is for if time taken to come from rds mobile app is more then it means app is install.
- If flag is false means app doesn't install in phone and then it will re-direct to playstore(App mentioned in fallback url).
There was a problem hiding this comment.
use const variables instead of let and var where ever it can be done
|
why there's so much changes in index.html file? |
|
When you uninstalled why it is opening github app not rds mobille app? |
|
With this PR if I am in android I have to mobile app regardless if I want to use RDS website? |
|
Tests are failing please have a look |
Due to some replacement of code it is shows much changes here. |
Resolved failing of test case. |
It is for demo purpose. |
Issue Open RDS app from www-site
Issue:
Real-Dev-Squad/mobile-app#269
Changes:
Recording:
WhatsApp.Video.2023-10-06.at.2.43.44.PM.mp4