Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test analytics script with official scripts #776

Merged
merged 5 commits into from
Dec 30, 2023

Conversation

satyam73
Copy link
Member

@satyam73 satyam73 commented Dec 20, 2023

Issue

Closes #792

What is the change?

Removed tests analytics scripts and added official scripts.

Example :
  • Done this
  • Made these changes

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

For visual or interaction changes. Please provide a video / screenshot.

Example:

Before :
Image/Video

After :
Image/Video

Note :
What to delete and what not to

  • Keep the headings and answer the questions.
  • Delete the examples
  • Delete the description below headings What is the change? & Before/After Screenshots

@satyam73 satyam73 self-assigned this Dec 20, 2023
Copy link

cloudflare-workers-and-pages bot commented Dec 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e29c3d
Status: ✅  Deploy successful!
Preview URL: https://15e65ac8.www-rds.pages.dev
Branch Preview URL: https://analytics-replace-test-scrip.www-rds.pages.dev

View logs

@satyam73 satyam73 marked this pull request as ready for review December 20, 2023 13:19
@satyam73 satyam73 changed the title chore: replace test analytics script with official scripts [Do-not-merge] chore: replace test analytics script with official scripts Dec 20, 2023
@satyam73 satyam73 changed the title [Do-not-merge] chore: replace test analytics script with official scripts [DO-NOT-MERGE] Replace test analytics script with official scripts Dec 21, 2023
@satyam73 satyam73 changed the title [DO-NOT-MERGE] Replace test analytics script with official scripts Replace test analytics script with official scripts Dec 27, 2023
@satyam73 satyam73 linked an issue Dec 27, 2023 that may be closed by this pull request
10 tasks
@satyam73 satyam73 merged commit 886614a into develop Dec 30, 2023
3 checks passed
@satyam73 satyam73 deleted the analytics/replace-test-scripts branch December 30, 2023 18:31
@satyam73 satyam73 mentioned this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RDS officlal analytics scripts in ember app
2 participants