Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join form submit restriction #881

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

satyam73
Copy link
Member

@satyam73 satyam73 commented Mar 28, 2024

Date: 28-03-2024

Developer Name: Satyam Bajpai


Issue Ticket Number:-

Description:

Removed the join form submit restriction by uncommenting the code.

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

image

Copy link

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 315d3be
Status: ✅  Deploy successful!
Preview URL: https://d9e3886c.www-rds.pages.dev
Branch Preview URL: https://fix-join-form-restriction.www-rds.pages.dev

View logs

@satyam73 satyam73 self-assigned this Mar 28, 2024
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the test of this file?

@satyam73
Copy link
Member Author

Can you share the test of this file?

Tests aren't needed for this since only uncommenting the parts of the code

@iamitprakash iamitprakash merged commit 94f7f53 into develop Apr 18, 2024
3 checks passed
@iamitprakash iamitprakash deleted the fix/join-form-restriction branch April 18, 2024 19:56
@palakgupta2712 palakgupta2712 mentioned this pull request Apr 20, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants