Temp fix for allowing archived users to use the /join page #896
Conversation
ankushdharkar
changed the title
ankushdharkar
changed the title
| } else { | ||
| alert('You must be logged in to continue'); |
There was a problem hiding this comment.
Another small UX improvement. The button click was silently failing when users were not logged in
There was a problem hiding this comment.
Nice. I really thought the page was just broken.
There was a problem hiding this comment.
Wait, just read the description. I thought this was a fix that hitting the "Start" button does nothing if you are not logged in, and was fixing that.
There was a problem hiding this comment.
Video: https://youtu.be/d5f0NCNOLvg
There was a problem hiding this comment.
@entropyReverser That doesn't require a fix as the workaround is to log in using the "Sign in with GitHub" button on top-right
There was a problem hiding this comment.
Yeah. I know, but I would have liked an alert like this of "Please log in to continue"
There was a problem hiding this comment.
@entropyReverser That's exactly what this UX adds :)
|
Will have to check, If we need to do backend changes to accept response from archived users |
|
@prakashchoudhary07 Already tested the flow by marking myself as |
Date: Aug 16, 2024
Developer Name: Ankush Dharkar
Issue Ticket Number:-
Description:
Temporarily unblocks archived users to submit the /join form. Cron job seems to be marking users not in discord as archived and blocking them
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )