Dev to main Sync #932
Merged
Dev to main Sync #932
+111
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes - added tests for it - removes /debug pages from the dev feature flags
- Adds toast as on both success as well failure - Adds test case covering the non-success reponse from serves
[feat] Toggle Super_user privileges
|
Why you are removing FF as the backend changes are done now |
Puts /debug page behind ff for testing before removing it
Deploying www-rds with
|
| Latest commit: |
1bb3076
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://470e0822.www-rds.pages.dev |
| Branch Preview URL: | https://develop.www-rds.pages.dev |
Addressed it in the latest pr updated the PR description as well |
shubhdevelop
requested review from
prakashchoudhary07,
iamitprakash,
satyam73,
yesyash and
Achintya-Chatterjee
vinit717
approved these changes
Sep 19, 2024
Achintya-Chatterjee
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
19th September, 2024Developer Name: @shubhdevelop
Issue Ticket Number
PR's Going in These Sync
Description
Documentation Updated?
Under Feature Flag
Database Changes
updated the data model documentation
Breaking Changes
Development Tested?
Screenshots
Screencast
Testing in staging
Screencast.from.19-09-24.02.03.40.AM.IST.webm
Screencast.from.19-09-24.02.05.00.AM.IST.webm
Under Feature flag
Screencast.from.19-09-24.03.39.14.PM.IST.webm
Screencast.from.19-09-24.03.44.52.PM.IST.webm
Test Coverage
Screenshot 1
Additional Notes
Link to the Design Doc
https://docs.google.com/document/d/17khsviClkNVNYH4Xy5Pkk98Xvrid1jH1jL9QtfGp7aw/edit?usp=sharing