Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription feature #936

Merged
merged 21 commits into from
Oct 12, 2024
Merged

Subscription feature #936

merged 21 commits into from
Oct 12, 2024

Conversation

tejaskh3
Copy link
Contributor

@tejaskh3 tejaskh3 commented Oct 8, 2024

Date: 8 oct, 2024

Developer Name: @tejaskh3


Issue Ticket Number:-

Description:

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • [] No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

screen-capture.27.webm

@tejaskh3 tejaskh3 self-assigned this Oct 8, 2024
@tejaskh3 tejaskh3 marked this pull request as draft October 8, 2024 15:58
app/controllers/subscribe.js Outdated Show resolved Hide resolved
app/styles/subscribe.module.css Show resolved Hide resolved
tests/unit/services/subcribe-test.js Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Oct 8, 2024

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 65aa25c
Status: ✅  Deploy successful!
Preview URL: https://5b5b3aad.www-rds.pages.dev
Branch Preview URL: https://subscription-feature.www-rds.pages.dev

View logs

@tejaskh3 tejaskh3 mentioned this pull request Oct 8, 2024
9 tasks
@tejaskh3 tejaskh3 marked this pull request as ready for review October 8, 2024 18:15
MehulKChaudhari
MehulKChaudhari previously approved these changes Oct 8, 2024
@MehulKChaudhari
Copy link
Member

@tejaskh3 Please add tests of it

Copy link
Member

@MehulKChaudhari MehulKChaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest all the things looks good.

joyguptaa
joyguptaa previously approved these changes Oct 9, 2024
app/controllers/subscribe.js Outdated Show resolved Hide resolved
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see contents are shifting up after submission, please fix this

@tejaskh3
Copy link
Contributor Author

I do see contents are shifting up after submission, please fix this

fixed this issue sir please check again.

@vinit717
Copy link
Member

Can you update the video

@tejaskh3
Copy link
Contributor Author

Can you update the video

this is updated video sir, we have removed the modal.

@iamitprakash iamitprakash merged commit 9fb0f2c into develop Oct 12, 2024
3 checks passed
@iamitprakash iamitprakash deleted the subscription-feature branch October 12, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants