Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename sidebar to navbar #46

Merged
merged 14 commits into from
Mar 13, 2024
Merged

rename sidebar to navbar #46

merged 14 commits into from
Mar 13, 2024

Conversation

yesyash
Copy link
Contributor

@yesyash yesyash commented Mar 11, 2024 •
edited
Loading

Date: 11 Mar 2024

Developer Name: yash raj

Merge this after

Issue Ticket Number

Description

  • rename the sidebar to navbar as the same component will be used in mobile view.

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Test Coverage

image

@prakashchoudhary07 prakashchoudhary07 dismissed stale reviews from Achintya-Chatterjee and themself via 5b63a21 March 13, 2024 04:19
@yesyash yesyash merged commit 290533d into develop Mar 13, 2024
2 checks passed
@yesyash yesyash deleted the yash/sidebar-rename branch March 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashchoudhary07 prakashchoudhary07 prakashchoudhary07 approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesyash @prakashchoudhary07 @Achintya-Chatterjee