generated from RealDevSquad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 279
feat: add applicant image upload functionality #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| const skipWhenApplicationType = (middleware) => { | ||
| return (req, res, next) => { | ||
| if (req.body.type === "application") return next(); | ||
| return middleware(req, res, next); | ||
| }; | ||
| }; | ||
|
|
||
| module.exports = skipWhenApplicationType; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Missing rate limiting High
Copilot Autofix
AI 7 days ago
In general, this should be fixed by introducing a rate-limiting middleware (for example using the well-known
express-rate-limitpackage) and applying it to the sensitive route(s) that perform authentication/authorization and potentially expensive operations. The middleware should be configured with reasonablewindowMsandmaxvalues to balance protection and usability, and should be placed early enough in the middleware chain that expensive handlers (like file parsing and business logic) are not invoked when the limit is exceeded.For this specific code, the most targeted change that does not alter existing functionality is:
express-rate-limitat the top ofroutes/users.js./pictureupload route (e.g., something likeuserPictureUploadLimiterallowing a small number of uploads per minute per IP)./picturePOST route before the Multerupload.single("profile")middleware, so that excessive requests are rejected before file parsing and subsequent authorization/Discord checks.Concretely:
routes/users.jsafter the existingrequirestatements, addconst rateLimit = require("express-rate-limit");and a newconst userPictureUploadLimiter = rateLimit({ ... })definition.router.post("/picture", ...)route to insertuserPictureUploadLimiterbetweenauthenticateandupload.single("profile").No other routes need to be changed to address this specific alert; the change remains tightly scoped to the flagged route and uses a standard, well-known dependency.