Skip to content

fix: test expectations for idle user #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prakashchoudhary07 merged 3 commits into from
Feb 19, 2026
Merged

fix: test expectations for idle user #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3594838
fix: reset allMavens array and update test expectations for idle user…
vinit717 Feb 17, 2026
bac2136
fix: initialize allMavens array to prevent unintended side effects
vinit717 Feb 18, 2026
30171c3
fix: change allMavens declaration from let to const for better immuta…
vinit717 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions models/discordactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ const updateIdleUsersOnDiscord = async (dev) => {
let allUsersHavingGroupIdle = [];
let groupIdleRole;
let groupIdleRoleId;
const allMavens = [];

try {
groupIdleRole = await getGroupRole("group-idle");
Expand Down
8 changes: 4 additions & 4 deletions test/unit/models/discordactions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,7 @@ describe("discordactions", function () {

getDiscordMembers[3] = {
...getDiscordMembers[3],
roles: ["1212121212"],
roles: ["3434343434"],
};

await addUser(userData[0]);
Expand Down Expand Up @@ -1079,11 +1079,11 @@ describe("discordactions", function () {
await cleanDb();
});

it("should return totalIdleUsers as 1,totalArchivedUsers as 0, totalRoleToBeAdded as 1", async function () {
it("should return totalIdleUsers as 2,totalArchivedUsers as 0, totalRoleToBeAdded as 2", async function () {
const dev = "true";
const res = await updateIdleUsersOnDiscord(dev);
expect(res.totalIdleUsers).to.be.equal(1);
expect(res.totalUserRoleToBeAdded).to.be.equal(1);
expect(res.totalIdleUsers).to.be.equal(2);
expect(res.totalUserRoleToBeAdded).to.be.equal(2);
expect(res.totalUserRoleToBeRemoved).to.be.equal(1);
expect(res.totalArchivedUsers).to.be.equal(0);
});
Expand Down
Loading