-
Notifications
You must be signed in to change notification settings - Fork 152
feat: add review step for new stepper [Onboarding-Form] #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e794f60
feat: add review step for new stepper
MayankBansal12 c4a96bd
feat: add thank you screen for new stepper
MayankBansal12 ec0cbfc
refactor: use structure for step data and replace hardcoded storage keys
MayankBansal12 51ed474
Merge branch 'feat/new-step-3' into feat/review-step
MayankBansal12 c3fd942
refactor: use getter func for review step button
MayankBansal12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| <div class="step-container"> | ||
| <div class="form-header__text"> | ||
| <h1 class="section-heading">{{@heading}}</h1> | ||
| <p class="section-instruction">{{@subHeading}}</p> | ||
| </div> | ||
|
|
||
| <div class="review-section"> | ||
| <div class="review-section__header"> | ||
| <h3 class="review-section__title">Personal Information</h3> | ||
| <Reusables::Button | ||
| @text="Edit" | ||
| @variant="light btn--sm" | ||
| @test="edit-step-1" | ||
| @type="button" | ||
| @onClick={{fn @navigateToStep 1}} | ||
| /> | ||
| </div> | ||
| <div class="review-section__content"> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Full Name:</span> | ||
| <span class="review-field__value {{unless this.stepData.one.fullName 'review-field__value--missing'}}"> | ||
| {{if this.stepData.one.fullName this.stepData.one.fullName 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Location:</span> | ||
| <span class="review-field__value {{unless this.locationDisplay 'review-field__value--missing'}}"> | ||
| {{this.locationDisplay}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Applying as:</span> | ||
| <span class="review-field__value {{unless this.stepData.one.role 'review-field__value--missing'}}"> | ||
| {{if this.stepData.one.role this.stepData.one.role 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Profile Image:</span> | ||
| <span class="review-field__value review-field__value--empty"> | ||
| Not uploaded | ||
| </span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="review-section"> | ||
| <div class="review-section__header"> | ||
| <h3 class="review-section__title">Professional Details</h3> | ||
| <Reusables::Button | ||
| @text="Edit" | ||
| @variant="light btn--sm" | ||
| @test="edit-step-2" | ||
| @type="button" | ||
| @onClick={{fn @navigateToStep 2}} | ||
| /> | ||
| </div> | ||
| <div class="review-section__content"> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Skills:</span> | ||
| <span class="review-field__value {{unless this.stepData.two.skills 'review-field__value--missing'}}"> | ||
| {{if this.stepData.two.skills this.stepData.two.skills 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Institution/Company:</span> | ||
| <span class="review-field__value {{unless this.stepData.two.company 'review-field__value--missing'}}"> | ||
| {{if this.stepData.two.company this.stepData.two.company 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Introduction:</span> | ||
| <span class="review-field__value {{unless this.stepData.two.introduction 'review-field__value--missing'}}"> | ||
| {{if this.stepData.two.introduction this.stepData.two.introduction 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="review-section"> | ||
| <div class="review-section__header"> | ||
| <h3 class="review-section__title">Hobbies & Interests</h3> | ||
| <Reusables::Button | ||
| @text="Edit" | ||
| @variant="light btn--sm" | ||
| @test="edit-step-3" | ||
| @type="button" | ||
| @onClick={{fn @navigateToStep 3}} | ||
| /> | ||
| </div> | ||
| <div class="review-section__content"> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Hobbies:</span> | ||
| <span class="review-field__value {{unless this.stepData.three.hobbies 'review-field__value--missing'}}"> | ||
| {{if this.stepData.three.hobbies this.stepData.three.hobbies 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Fun Fact:</span> | ||
| <span class="review-field__value {{unless this.stepData.three.funFact 'review-field__value--missing'}}"> | ||
| {{if this.stepData.three.funFact this.stepData.three.funFact 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="review-section"> | ||
| <div class="review-section__header"> | ||
| <h3 class="review-section__title">Social Profiles</h3> | ||
| <Reusables::Button | ||
| @text="Edit" | ||
| @variant="light btn--sm" | ||
| @test="edit-step-4" | ||
| @type="button" | ||
| @onClick={{fn @navigateToStep 4}} | ||
| /> | ||
| </div> | ||
| <div class="review-section__content"> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Phone Number:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.phoneNumber 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.phoneNumber this.stepData.four.phoneNumber 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Twitter:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.twitter 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.twitter this.stepData.four.twitter 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| {{#if this.showGitHub}} | ||
| <div class="review-field"> | ||
| <span class="review-field__label">GitHub:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.github 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.github this.stepData.four.github 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| {{/if}} | ||
| <div class="review-field"> | ||
| <span class="review-field__label">LinkedIn:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.linkedin 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.linkedin this.stepData.four.linkedin 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Instagram:</span> | ||
| <span class="review-field__value {{if this.stepData.four.instagram '' 'review-field__value--empty'}}"> | ||
| {{if this.stepData.four.instagram this.stepData.four.instagram 'Not uploaded'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Peerlist:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.peerlist 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.peerlist this.stepData.four.peerlist 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| {{#if this.showBehance}} | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Behance:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.behance 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.behance this.stepData.four.behance 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| {{/if}} | ||
| {{#if this.showDribble}} | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Dribble:</span> | ||
| <span class="review-field__value {{unless this.stepData.four.dribble 'review-field__value--missing'}}"> | ||
| {{if this.stepData.four.dribble this.stepData.four.dribble 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| {{/if}} | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="review-section"> | ||
| <div class="review-section__header"> | ||
| <h3 class="review-section__title">Why Real Dev Squad?</h3> | ||
| <Reusables::Button | ||
| @text="Edit" | ||
| @variant="light btn--sm" | ||
| @test="edit-step-5" | ||
| @type="button" | ||
| @onClick={{fn @navigateToStep 5}} | ||
| /> | ||
| </div> | ||
| <div class="review-section__content"> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Why you want to join Real Dev Squad?:</span> | ||
| <span class="review-field__value {{unless this.stepData.five.whyRds 'review-field__value--missing'}}"> | ||
| {{if this.stepData.five.whyRds this.stepData.five.whyRds 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">Hours per week:</span> | ||
| <span class="review-field__value {{unless this.stepData.five.numberOfHours 'review-field__value--missing'}}"> | ||
| {{if this.stepData.five.numberOfHours this.stepData.five.numberOfHours 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| <div class="review-field"> | ||
| <span class="review-field__label">How did you hear about us?:</span> | ||
| <span class="review-field__value {{unless this.stepData.five.foundFrom 'review-field__value--missing'}}"> | ||
| {{if this.stepData.five.foundFrom this.stepData.five.foundFrom 'Not provided'}} | ||
| </span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import Component from '@glimmer/component'; | ||
| import { tracked } from '@glimmer/tracking'; | ||
| import { getLocalStorageItem } from '../../utils/storage'; | ||
| import { STEP_DATA_STORAGE_KEY } from '../../constants/new-join-form'; | ||
|
|
||
| export default class NewStepSixComponent extends Component { | ||
| @tracked stepData = { | ||
| one: {}, | ||
| two: {}, | ||
| three: {}, | ||
| four: {}, | ||
| five: {}, | ||
| }; | ||
|
|
||
| constructor(...args) { | ||
| super(...args); | ||
| this.loadAllStepData(); | ||
| } | ||
|
|
||
| loadAllStepData() { | ||
| this.stepData.one = JSON.parse( | ||
| getLocalStorageItem(STEP_DATA_STORAGE_KEY.stepOne), | ||
| ); | ||
| this.stepData.two = JSON.parse( | ||
| getLocalStorageItem(STEP_DATA_STORAGE_KEY.stepTwo), | ||
| ); | ||
| this.stepData.three = JSON.parse( | ||
| getLocalStorageItem(STEP_DATA_STORAGE_KEY.stepThree), | ||
| ); | ||
| this.stepData.four = JSON.parse( | ||
| getLocalStorageItem(STEP_DATA_STORAGE_KEY.stepFour), | ||
| ); | ||
| this.stepData.five = JSON.parse( | ||
| getLocalStorageItem(STEP_DATA_STORAGE_KEY.stepFive), | ||
| ); | ||
| } | ||
|
|
||
| get userRole() { | ||
| return this.stepData.one.role || ''; | ||
| } | ||
|
|
||
| get showGitHub() { | ||
| return this.userRole === 'Developer'; | ||
| } | ||
|
|
||
| get showBehance() { | ||
| return this.userRole === 'Designer'; | ||
| } | ||
|
|
||
| get showDribble() { | ||
| return this.userRole === 'Designer'; | ||
| } | ||
|
|
||
| get locationDisplay() { | ||
| return `${this.stepData.one.city}, ${this.stepData.one.state}, ${this.stepData.one.country}`; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <div class="thank-you-screen" data-test="thank-you-screen"> | ||
| <div class="thank-you-screen__logo" data-test="thank-you-logo"> | ||
| <FaIcon @icon="check" @size="2x" /> | ||
| </div> | ||
|
|
||
| <div class="form-header__text"> | ||
| <h1 class="section-heading">{{@firstName}}, thank you for applying to RDS.</h1> | ||
| <p class="section-instruction">Great work filling up the application. However, it takes more to join us early.</p> | ||
| </div> | ||
|
|
||
| <div class="thank-you-screen__info-container"> | ||
| <div class="thank-you-screen__info-item--bullet"> | ||
| Head over to Application Tracking Page. | ||
| </div> | ||
|
|
||
| <div class="thank-you-screen__info-item--bullet"> | ||
| Checkout AI review and and edit your application to improve application rank. | ||
| </div> | ||
|
|
||
| <div class="thank-you-screen__info-item--bullet"> | ||
| Complete quests to improve your ranking and increase your chances of early reviews. | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="application-id"> | ||
| <h3>Application ID</h3> | ||
| <p>{{@applicationId}}</p> | ||
| </div> | ||
|
|
||
| <div class="thank-you-screen__actions"> | ||
| <Reusables::Button @text="Track application" @variant="dark" @test="track-application" @type="button" /> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.