upgrade oauth to support django 4+ #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job edu ! |
|
@larslevie and @aaronvb this is the fix on django oauth. Let me know when it is published to fury. |
|
@marzullofp @aaronvb Since this is a breaking change for older versions of Django, should this be a major version bump? Probably also want to add a note that this only compatible with Django >= 2.0. |
larslevie
force-pushed
the
upgrade-oauth
branch
2 times, most recently
from
a68cdb5 to
2174ab1
Compare
kevin1024
approved these changes
Nov 29, 2023
larslevie
force-pushed
the
master
branch
2 times, most recently
from
331a377 to
ecdc99b
Compare
larslevie
force-pushed
the
upgrade-oauth
branch
from
2174ab1 to
6814ffb
Compare
larslevie
force-pushed
the
upgrade-oauth
branch
from
7276151 to
34c2a56
Compare
until we can figure out how to do it correctly and still be able to run them locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
django-admin-oauth2in order to support Django 4+.Solution
urlwithre_pathinoauthadmin/urls.py.setup.py.README.md.Validation
Evidence
django-admin-oauth2now supports django 4+.Tests executed
django-admin-oauth2in RealLeads and passed existing tests.