Add GetMappedCPL method to root moviebuff package#16
Merged
sasipriyags merged 4 commits intomasterfrom Dec 9, 2025
Merged
Conversation
Co-authored-by: navratan3 <109721452+navratan3@users.noreply.github.com>
Co-authored-by: navratan3 <109721452+navratan3@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add GetMappedCPL method and MappedCPL type to moviebuff package
Add GetMappedCPL method to root moviebuff package
Dec 9, 2025
navratan3
requested changes
Dec 9, 2025
go.mod
Outdated
| github.com/stretchr/testify v1.4.0 | ||
| ) | ||
|
|
||
| replace github.com/RealImage/moviebuff-sdk-go/v2 => ./v2 |
Contributor
Contributor
Author
moviebuff_test.go
Outdated
|
|
||
| } | ||
|
|
||
| func TestMoviebuff_GetMappedCPL(t *testing.T) { |
Contributor
There was a problem hiding this comment.
The unit test here seems redundant as we already have one for v2. Since this method is just a wrapper around v2 we don't need a unit test
Contributor
Author
There was a problem hiding this comment.
Removed the redundant unit tests since this is just a wrapper around v2. Changes in commit 354e13e.
Co-authored-by: navratan3 <109721452+navratan3@users.noreply.github.com>
sasipriyags
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
GetMappedCPLin the root moviebuff package to match the v2 package implementation from PR #15. The root package acts as a simplified wrapper that removes context parameters.Changes
MappedCPL,MappedCPLMovie,MappedCPLPart)v2.GetMappedCPL(context.Background(), cplID)Usage
Follows the established pattern where root package methods wrap v2 methods with
context.Background()for backward compatibility. No additional unit tests are included as the wrapper relies on existing v2 package test coverage.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.